Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loosen fastapi and uvicorn requirements #229

Merged
merged 1 commit into from Dec 20, 2023
Merged

Loosen fastapi and uvicorn requirements #229

merged 1 commit into from Dec 20, 2023

Conversation

izellevy
Copy link
Collaborator

@izellevy izellevy commented Dec 14, 2023 •
edited by igiloh-pinecone

Problem

Canopy SDK cannot be installed on all fastapi and unicorn versions.
Resolves: #221

Solution

Loosen the requirement for uvicorn and fastapi

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Describe specific steps for validating this change.

@izellevy izellevy mentioned this pull request Dec 14, 2023
Closed
2 tasks
@izellevy izellevy changed the title Loosen reqs Loosen fastapi and uvicorn requirements Dec 14, 2023
igiloh-pinecone
igiloh-pinecone approved these changes Dec 17, 2023
View reviewed changes
Copy link
Collaborator

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@izellevy I've marked this issue to automatically resolve #221.
I would suggest to also comment in that issue, explaining that we're loosing the requirements at users' request, but get guarantee full testability with any arbitrary FastAPI version.

@izellevy
Copy link
Collaborator Author

@igiloh-pinecone already commented on #221

@izellevy izellevy added this pull request to the merge queue Dec 17, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 17, 2023
@igiloh-pinecone igiloh-pinecone added this pull request to the merge queue Dec 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2023
@izellevy izellevy added this pull request to the merge queue Dec 20, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 20, 2023
@izellevy izellevy added this pull request to the merge queue Dec 20, 2023
Merged via the queue into pinecone-io:main with commit f2f20f2 Dec 20, 2023
10 checks passed
@izellevy izellevy deleted the feature/loosen_fastapi_requirements branch December 20, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igiloh-pinecone igiloh-pinecone igiloh-pinecone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not install canopy with latest fastapi > 0.92.0?
2 participants
@izellevy @igiloh-pinecone