Move chunk id generation to base

[izellevy]

Problem

Every chunker has its own way of creating chunk ids. We should generalise that to prevent discrepancies.

Solution

Created a function in the base and changed all child classes to call that function instead.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update
• Infrastructure change (CI configs, etc)
• Non-code change (docs, etc)
• None of the above: (explain here)

Test Plan

Describe specific steps for validating this change.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[igiloh-pinecone]

LGTM!