Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

__init__ fix: CohereEncoder -> CohereRecordEncoder #264

Merged
merged 1 commit into from Jan 24, 2024

Conversation

tomaarsen
Copy link
Contributor

Problem

CohereEncoder (i.e. the class from pinecone_text) was being exported via __init__.py rather than CohereRecordEncoder.

Solution

I replaced CohereEncoder with CohereRecordEncoder.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

You can try to import CohereRecordEncoder via canopy.knowledge_base.record_encoder - this was not possible before.

  • Tom Aarsen

Copy link
Collaborator

@igiloh-pinecone igiloh-pinecone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tomaarsen thanks! Good catch!

We should probably change our naming convention to be a bit more explicit, to prevent similar mistakes in the future.

@igiloh-pinecone igiloh-pinecone added this pull request to the merge queue Jan 24, 2024
@igiloh-pinecone igiloh-pinecone mentioned this pull request Jan 24, 2024
7 tasks
Merged via the queue into pinecone-io:main with commit 6ba92c5 Jan 24, 2024
7 checks passed
@tomaarsen tomaarsen deleted the fix/cohere branch January 24, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants