Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Random query comment #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

loisaidasam
Copy link

Problem

After elaborate evaluation, I wanted to add a warning about querying random points in vector space.

/cc @bhentsch @ben-ogden and Chris Afiesh

In my experience the recall as compared to the ground truth/brute force nearest neighbors is on the scale of 0.14ish when querying entirely random locations

Solution

Added a simple warning to the locustfile in case anyone else is starting off with this as their basis for testing

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

No changes worth testing, just a comment

@loisaidasam
Copy link
Author

Oh right, I guess I added a few formatting changes as well, nothing functionally different though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant