Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add shared time markers to phase portraits #359

Merged
merged 5 commits into from
Jun 30, 2023
Merged

add shared time markers to phase portraits #359

merged 5 commits into from
Jun 30, 2023

Conversation

qinqian
Copy link
Collaborator

@qinqian qinqian commented Jun 25, 2023 •
edited by cameronraysmith
Loading

  1. improve phase portraint with more information such as u and s offsets, and switching points;
  2. use t0 and shared time in marker selection

@cameronraysmith cameronraysmith added this to the 0.1.3 milestone Jun 27, 2023
@cameronraysmith cameronraysmith added the enhancement New feature or request label Jun 27, 2023
cameronraysmith
cameronraysmith approved these changes Jun 30, 2023
View reviewed changes
Copy link
Collaborator

@cameronraysmith cameronraysmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • lint summarize
  • update lock file

@cameronraysmith cameronraysmith changed the title T0 sharedtime selection add shared time markers to phase portraits Jun 30, 2023
@cameronraysmith cameronraysmith linked an issue Jun 30, 2023 that may be closed by this pull request
indicate shared time boundaries and offsets on phase portraits #363
Closed
@codecov
Copy link

codecov bot commented Jun 30, 2023

Codecov Report

Merging #359 (049e69d) into master (59dcc5f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   19.27%   19.27%           
=======================================
  Files          28       28           
  Lines        3460     3460           
  Branches      465      465           
=======================================
  Hits          667      667           
  Misses       2784     2784           
  Partials        9        9
Impacted Files Coverage Δ
pyrovelocity/config.py 25.71% <ø> (ø)

@cameronraysmith cameronraysmith merged commit 15f230f into pinellolab:master Jun 30, 2023
9 checks passed
cameronraysmith added a commit that referenced this pull request Jan 3, 2024
@qinqian @cameronraysmith
add shared time markers to phase portraits (#359)
8ca20c5 
* compare t0 and maximum shared time; add u0/s0/uinf/sinf in phase portraits
* update lock file

---------

Co-authored-by: Cameron Smith <cameron.ray.smith@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cameronraysmith cameronraysmith cameronraysmith approved these changes

Assignees

@cameronraysmith cameronraysmith

@qinqian qinqian

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.1.3
Development

Successfully merging this pull request may close these issues.

indicate shared time boundaries and offsets on phase portraits
2 participants
@qinqian @cameronraysmith