feature: Query Editor #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Breezewish <me@breeswish.org>
Signed-off-by: Breezewish <me@breeswish.org>
baurine
reviewed
Aug 3, 2020
| } | ||
| setRunning(false) | ||
| editor.current?.editor.focus() | ||
| }, []) |
There was a problem hiding this comment.
Not sure whether we can use useClientRequest() to simplify the code like this:
const {data, isLoading, error, sendRequest: handleRun} = useClientRequest((cancelToken) =>
client.getInstance().queryEditorRun({
max_rows: MAX_DISPLAY_ROWS,
statements: editor.current?.editor.getValue(),
}, {cancelToken}),
{ immediate: false, afterRequest: () => editor.current?.editor.focus() }
)
Then we don't need results and isRunning anymore.
For error, we can show an ErrorBar component instead of Modal.error().
There was a problem hiding this comment.
Unlike queries, for operational errors mostly there will be a modal dialog to stop further user actions. Displaying modal dialog using this pattern can be pretty hard.
ti-srebot
approved these changes
Aug 3, 2020
breezewish
added a commit
that referenced
this pull request
Sep 8, 2020
Signed-off-by: Breezewish <me@breeswish.org> (cherry picked from commit 2a372d4)
breezewish
added a commit
that referenced
this pull request
Sep 8, 2020
* feature: Query Editor (#713) * Backend: replace UNIX_TIMESTAMP with FROM_UNIXTIME in statement query (#731) * test: Stablize e2e tests (#732) * ui: Add store location tree (#728) * log_search: Display instance port (#722) * ui: show store location topology (#719) * ui: Online Config (#733) * ui: Support sharing session (#741) * doc: Update to sig-diagnosis (#742) * statement: Display number of plans in the list (#746) * log search: return zip instead of tar or gzip (#724)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR impls a new feature Query Editor, as below: