Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: Support sharing session #741

Merged
merged 4 commits into from Aug 25, 2020
Merged

ui: Support sharing session #741

merged 4 commits into from Aug 25, 2020

Conversation

breezewish
Copy link
Member

TiDB Dashboard requires the knowledge of a high privilege account to work. It may not be friendly for 3rd-party (like PingCAP) remote access.

Sharing session allows a signed-in user to share its session to other people, so that other people can access TiDB Dashboard without knowing the credentials. Sharing session may extend the lifetime of the current session, so that a shared session is not allowed to be shared again.

image
image
image
image
image
image
image

Signed-off-by: Breezewish <me@breeswish.org>
Signed-off-by: Breezewish <me@breeswish.org>
Copy link
Collaborator

@baurine baurine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@breezewish breezewish merged commit e69c844 into master Aug 25, 2020
@breezewish breezewish deleted the share branch August 25, 2020 02:13
breezewish added a commit that referenced this pull request Sep 8, 2020
Signed-off-by: Breezewish <me@breeswish.org>
(cherry picked from commit e69c844)
breezewish added a commit that referenced this pull request Sep 8, 2020
* feature: Query Editor (#713)
* Backend: replace UNIX_TIMESTAMP with FROM_UNIXTIME in statement query (#731)
* test: Stablize e2e tests (#732)
* ui: Add store location tree (#728)
* log_search: Display instance port (#722)
* ui: show store location topology (#719)
* ui: Online Config (#733)
* ui: Support sharing session (#741)
* doc: Update to sig-diagnosis (#742)
* statement: Display number of plans in the list (#746)
* log search: return zip instead of tar or gzip (#724)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants