Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic Online Config UI #733

Merged
merged 9 commits into from
Aug 19, 2020
Merged

Basic Online Config UI #733

merged 9 commits into from
Aug 19, 2020

Conversation

breezewish
Copy link
Member

@breezewish breezewish commented Aug 10, 2020 •
edited
Loading

This PR partially implements #576

Some possible future improvements:

  1. Remove hard coded configuration items
  2. Give descriptions for configurations
  3. Allow modifying per-instance configurations
  4. Use select for boolean, use filtered input for numeric input

Some bugs:

  1. Spinner is not displayed when scrolled down

breezewish and others added 9 commits August 7, 2020 10:30
@breezewish
wip
eb0a9bf 
Signed-off-by: Breezewish <me@breeswish.org>
@breezewish
Configuration UI
1da92d1 
Signed-off-by: Breezewish <me@breeswish.org>
@breezewish
Merge remote-tracking branch 'origin/master' into config
3e5d9c9
@breezewish
Fix some case that boolean value cannot be updated
ce7e575 
Signed-off-by: Breezewish <me@breeswish.org>
@breezewish
Merge branch 'master' into config
63ddd8d
@breezewish
Fix lint issues
e554a49
@breezewish
Support TIDB_OVERRIDE_STATUS_ENDPOINT
2226d8d 
Signed-off-by: Breezewish <me@breeswish.org>
@breezewish
Update to v4.0.4
8b7879a 
Signed-off-by: Breezewish <me@breeswish.org>
@breezewish
Move StoreLocationTree to a more proper place
f8dfc57 
Signed-off-by: Breezewish <me@breeswish.org>
HunDunDM
HunDunDM approved these changes Aug 19, 2020
View reviewed changes
Copy link
Contributor

@HunDunDM HunDunDM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@breezewish breezewish merged commit 89fd495 into master Aug 19, 2020
@breezewish breezewish deleted the config branch August 19, 2020 13:20
breezewish added a commit that referenced this pull request Sep 8, 2020
@breezewish
ui: Online Config (#733)
4adf29a 
Signed-off-by: Breezewish <me@breeswish.org>
(cherry picked from commit 89fd495)
breezewish added a commit that referenced this pull request Sep 8, 2020
@breezewish
Release v2020.09.08.1 (#753)
a715a95 
* feature: Query Editor (#713)
* Backend: replace UNIX_TIMESTAMP with FROM_UNIXTIME in statement query (#731)
* test: Stablize e2e tests (#732)
* ui: Add store location tree (#728)
* log_search: Display instance port (#722)
* ui: show store location topology (#719)
* ui: Online Config (#733)
* ui: Support sharing session (#741)
* doc: Update to sig-diagnosis (#742)
* statement: Display number of plans in the list (#746)
* log search: return zip instead of tar or gzip (#724)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HunDunDM HunDunDM HunDunDM approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@breezewish @HunDunDM @ti-srebot