Handle no-expand tarballs with v1 manifests #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Signed-off-by: Nick Cameron <nrc@ncameron.org>
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
=======================================
Coverage 45.54% 45.54%
=======================================
Files 37 37
Lines 2874 2874
=======================================
Hits 1309 1309
Misses 1333 1333
Partials 232 232 Continue to review full report at Codecov.
|
july2993
approved these changes
May 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently based on top of #249.
This PR handles tarballs which just need to be saved to disk rather than untared. The first commit factors out a distinct error type for when a manifest has expired. I don't actually use this code (I don't think we need to handle this case before the initial release) but I think it will be useful later and I'd already written it.
PTAL @AstroProfundis