New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
collector: remove cputime (#970) #1009
collector: remove cputime (#970) #1009
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
/lgtm |
/lgtm |
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 973ac3d
|
/run-all-tests |
1 similar comment
/run-all-tests |
/merge |
/merge |
/run-all-tests |
/build |
/run-check-release-note |
cherry-pick #970 to release-5.0
You can switch your code base to this Pull Request by using git-extras:
# In br repo: git pr https://github.com/pingcap/br/pull/1009
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
solved #960
What is changed and how it works?
remove the CPU time recorded in summary.
At the same time, fix mis-collected checksum time collection, and put all summary info to zap log fields.
Check List
Tests
Simple restore log:
[2021/03/31 05:09:03.162 +00:00] [INFO] [collector.go:61] ["Full restore success summary"] [total-ranges=15] [ranges-succeed=15] [ranges-failed=0] [split-region=69.741025ms] [restore-checksum=36.549082ms] [restore-ranges=9] [Size=2697339] [total-take=3.064856286s] [total-kv=9000] [total-size=3.849MB] [average-speed=40.52MB/s]
Release Note