backup: set concurrency to 1 when ratelimit enabled #1015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/lgtm |
|
/run-all-tests |
… into conc1-when-ratelim-set
|
/lgtm |
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by writing |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 017fe85
|
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Apr 16, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-4.0 in PR #1025 |
ti-srebot
pushed a commit
to ti-srebot/br
that referenced
this pull request
Apr 16, 2021
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
|
cherry pick to release-5.0 in PR #1026 |
ti-chi-bot
pushed a commit
that referenced
this pull request
Apr 16, 2021
ti-chi-bot
pushed a commit
that referenced
this pull request
May 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix? #1007
What is changed and how it works?
When
--ratelimitwas set, degenerate to sequential backing up.Check List
Tests
(See backup:
--ratelimitdoesn't work as intended #1007)Release Note
--ratelimit.