Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: fix parquet parser for decimal type (#1272) #1277

Merged
merged 7 commits into from
Jun 25, 2021
Merged

lightning: fix parquet parser for decimal type (#1272) #1277

merged 7 commits into from
Jun 25, 2021

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #1272

What problem does this PR solve?

Fix parse parquet file when the corresponding type is decimal with FIXED_LEN_BYTE_ARRAY or BINARY

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

Related changes

Release note

  • Fix parquet parse when parse decimal type

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 24, 2021
Merged
@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Jun 24, 2021
@lonng lonng added this to the v5.0.3 milestone Jun 24, 2021
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • kennytm
  • lonng

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Jun 24, 2021
@lonng
Copy link
Contributor

lonng commented Jun 24, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 5015cff

@glorv
Copy link
Collaborator

glorv commented Jun 25, 2021

/run-all-tests

@3pointer
Copy link
Collaborator

/run-integration-tests

@glorv
Copy link
Collaborator

glorv commented Jun 25, 2021

/run-all-tests

@glorv
Copy link
Collaborator

glorv commented Jun 25, 2021

/run-all-tests

@kennytm
Copy link
Collaborator

kennytm commented Jun 25, 2021

/run-integration-test

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: a947215

@3pointer
Copy link
Collaborator

/run-integration-test

@3pointer
Copy link
Collaborator

looks like cdc has some breaking change in pingcap/tiflow#2070

@amyangfei
Copy link
Contributor

looks like cdc has some breaking change in pingcap/ticdc#2070

It is not a breaking change, but there exists a bug in TiCDC. Can add --data-dir "." as a workaround, TiCDC will fix it in 5.0.3

@kennytm
Copy link
Collaborator

kennytm commented Jun 25, 2021

@amyangfei is this flag available only on 5.0+?

@glorv
Copy link
Collaborator

glorv commented Jun 25, 2021

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: f092cd1

@amyangfei
Copy link
Contributor

@amyangfei is this flag available only on 5.0+?

ticdc 4.0 will also cherry-pick this change pingcap/tiflow#2069 @kennytm

@glorv
Copy link
Collaborator

glorv commented Jun 25, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit f5ef154 into pingcap:release-5.0 Jun 25, 2021
glorv pushed a commit to glorv/br that referenced this pull request Jun 28, 2021
@ti-chi-bot @glorv
lightning: fix parquet parser for decimal type (pingcap#1272) (pingca…
763381f 
…p#1277)
@glorv glorv mentioned this pull request Jun 28, 2021
Merged
glorv added a commit that referenced this pull request Jun 28, 2021
@glorv @ti-chi-bot
lightning: fix parquet parser for decimal type (#1272) (#1277) (#1293)
def9677 
Co-authored-by: Ti Chi Robot <ti-community-prow-bot@tidb.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennytm kennytm kennytm approved these changes

@lonng lonng lonng approved these changes

@Little-Wallace Little-Wallace Awaiting requested review from Little-Wallace

@glorv glorv Awaiting requested review from glorv

@overvenus overvenus Awaiting requested review from overvenus

Assignees

@glorv glorv

Labels
cherry-pick-approved component/import size/XL status/can-merge status/LGT2 LGTM2 type/bug-fix type/cherry-pick-for-release-5.0
Projects
None yet
Milestone
v5.0.3
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ti-chi-bot @lonng @glorv @3pointer @kennytm @amyangfei