Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: Remove statement from closure to prevent concurrent operation during backup system table #1449

Merged
merged 5 commits into from Dec 8, 2021

Conversation

joccau
Copy link
Member

@joccau joccau commented Nov 30, 2021

What problem does this PR solve?

Issue Number: close pingcap/tidb#29710

Cherry-pick from pingcap/tidb#29730

What is changed and how it works?

Release note

  • No release note

…ing backup system table (#29730)

Signed-off-by: joccau <zak.zhao@pingcap.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 30, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • kennytm

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

@joccau: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joccau
Copy link
Member Author

joccau commented Nov 30, 2021

/cc @YuJuncen @3pointer @fengou1 PTAL

@ti-chi-bot
Copy link
Member

@joccau: GitHub didn't allow me to request PR reviews from the following users: PTAL.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @YuJuncen @3pointer @fengou1 PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: joccau <zak.zhao@pingcap.com>
@joccau
Copy link
Member Author

joccau commented Dec 1, 2021

/run-integration_test

@ti-chi-bot ti-chi-bot added the status/LGT1 LGTM1 label Dec 6, 2021
@kennytm
Copy link
Collaborator

kennytm commented Dec 6, 2021

/run-integration-test

@ti-chi-bot ti-chi-bot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Dec 6, 2021
@kennytm
Copy link
Collaborator

kennytm commented Dec 7, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 83b9afb

@joccau joccau merged commit 0ef8d4c into pingcap:release-5.1 Dec 8, 2021
ti-chi-bot pushed a commit to ti-chi-bot/br that referenced this pull request Dec 8, 2021
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #1450.

@zhouqiang-cl zhouqiang-cl added this to the v5.1.4 milestone Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants