Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore: switch mode immediately when restore start. #473

Merged
merged 2 commits into from
Aug 26, 2020

Conversation

3pointer
Copy link
Collaborator

What problem does this PR solve?

Fix the issue that switch to import mode not work at first 5 minutes.

What is changed and how it works?

do switchToImportMode at first.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    There is no "switch to import mode" log if we finish restore in 5 minutes.

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • Fix the issue that switch to import mode not work at first 5 minutes.

@3pointer 3pointer requested review from glorv and kennytm August 26, 2020 11:12
Copy link
Collaborator

@glorv glorv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@glorv,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: tools(slack).

Copy link
Member

@overvenus overvenus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants