Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stats: disable stats by default (#693) #696

Merged
merged 3 commits into from
Jan 14, 2021

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 14, 2021

cherry-pick #693 to release-4.0
You can switch your code base to this Pull Request by using git-extras:

# In br repo:
git pr https://github.com/pingcap/br/pull/696

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/br.git pr/696:release-4.0-87eb3ed13336

What problem does this PR solve?

Disable backup stats by default. because of

  1. DumpStatsToJson is not stable
  2. It increases memory usage may cause BR OOM

What is changed and how it works?

  1. set cfg.IgnoreStats default to true
  2. if cfg.IgnoreStats is true, set statsLease to -1

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Note

  • Disable backup stats by default to avoid BR reached OOM issue during backup.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot added Priority/P0 Top priority issue. Must have an associated milestone release-blocker type/4.0-cherry-pick labels Jan 14, 2021
@glorv
Copy link
Collaborator

glorv commented Jan 14, 2021

LGTM

@ti-srebot ti-srebot added the status/LGT1 LGTM1 label Jan 14, 2021
@overvenus
Copy link
Member

LGTM

@ti-srebot ti-srebot added status/LGT2 LGTM2 and removed status/LGT1 LGTM1 labels Jan 14, 2021
@ti-srebot
Copy link
Contributor Author

@jebter, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: migrate(slack).

@3pointer 3pointer merged commit e8a906b into pingcap:release-4.0 Jan 14, 2021
@jebter
Copy link

jebter commented Jan 14, 2021

/merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority/P0 Top priority issue. Must have an associated milestone release-blocker status/LGT2 LGTM2 type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants