add auto goimports into Makefile #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
zhouqiang-cl
reviewed
Feb 3, 2020
Makefile
Outdated
| $(GO) fmt ./... | ||
|
|
||
| groupimports: |
There was a problem hiding this comment.
Did we need to install goimport first
There was a problem hiding this comment.
Yes! Though goimports is auto installed as golang.org/x/tools is an indirect dependency, it's still necessary to check and install.
|
We should also add this into the CI test. |
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Codecov Report
@@ Coverage Diff @@
## master #182 +/- ##
=========================================
Coverage ? 39.47%
=========================================
Files ? 17
Lines ? 608
Branches ? 0
=========================================
Hits ? 240
Misses ? 337
Partials ? 31Continue to review full report at Codecov.
|
|
/test |
1 similar comment
|
/test |
sjwsl
pushed a commit
to sjwsl/chaos-mesh
that referenced
this pull request
May 6, 2021
* add auto goimports into Makefile Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yang Keao keao.yang@yahoo.com
What problem does this PR solve?
Add
goimportscommand into Makefile.What is changed and how does it work?
Diff check has been added to CI to ensure every PR has been formatted and yaml has been regenerated.
Tests