Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add etcd iochaos example #224

Merged
merged 1 commit into from Feb 12, 2020
Merged

Add etcd iochaos example #224

merged 1 commit into from Feb 12, 2020

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Feb 12, 2020

Signed-off-by: yeya24 yb532204897@gmail.com

What problem does this PR solve?

Fixes #216.

Etcd can achieve the same purpose for iochaos testing and it is easier with the help of etcdctl.

Verification:

# with iochaos delay
# etcdctl check perf
 60 / 60 Boooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo! 100.00% 1m0s
FAIL: Throughput too low: 79 writes/s
Slowest request took too long: 6.761501s
Stddev too high: 1.384703s
FAIL

# no iochaos
# etcdctl check perf
 60 / 60 Boooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooo! 100.00% 1m0s
PASS: Throughput is 150 writes/s
PASS: Slowest request took 0.029531s
PASS: Stddev is 0.001335s
PASS

cc @Yisaer

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: yeya24 <yb532204897@gmail.com>
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl
Copy link
Contributor

@cwen0 @Yisaer PTAL

@codecov-io
Copy link

Codecov Report

Merging #224 into master will increase coverage by 2.86%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   40.78%   43.64%   +2.86%     
==========================================
  Files          20       18       -2     
  Lines         738      685      -53     
==========================================
- Hits          301      299       -2     
+ Misses        404      353      -51     
  Partials       33       33
Impacted Files Coverage Δ
controllers/timechaos_controller.go
api/v1alpha1/timechaos_types.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21cc785...15f1ff6. Read the comment docs.

Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thanks for your contribution. @yeya24

@Yisaer Yisaer merged commit cadc4fb into chaos-mesh:master Feb 12, 2020
@yeya24 yeya24 deleted the io-examples branch February 12, 2020 12:10
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Signed-off-by: yeya24 <yb532204897@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add simple IOChaos example with mysql
4 participants