Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify target #249

Merged
merged 2 commits into from Feb 17, 2020
Merged

specify target #249

merged 2 commits into from Feb 17, 2020

Conversation

YangKeao
Copy link
Member

Signed-off-by: Yang Keao keao.yang@yahoo.com

What problem does this PR solve?

Fix make error and make test error on macos

What is changed and how does it work?

By specifying target for several files.

Check List

Tests

  • Unit test
  • E2E test
  • Manual test @cwen0 Help!

Code changes

  • Has Go code change

Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@codecov-io
Copy link

Codecov Report

Merging #249 into master will increase coverage by 9.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   38.12%   47.87%   +9.75%     
==========================================
  Files          33       23      -10     
  Lines        1448     1059     -389     
==========================================
- Hits          552      507      -45     
+ Misses        825      484     -341     
+ Partials       71       68       -3
Impacted Files Coverage Δ
pkg/ptrace/ptrace_linux.go 65.55% <ø> (ø)
pkg/ptrace/cwrapper_linux.go 100% <ø> (ø)
pkg/time/time_linux.go 55.1% <ø> (ø)
controllers/podchaos_controller.go 100% <0%> (ø) ⬆️
controllers/iochaos_controller.go 100% <0%> (ø) ⬆️
controllers/networkchaos_controller.go 100% <0%> (ø) ⬆️
pkg/chaosdaemon/netem_server.go
pkg/chaosdaemon/types.go
pkg/chaosdaemon/http.go
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 261f79b...af91e8f. Read the comment docs.

zhouqiang-cl
zhouqiang-cl previously approved these changes Feb 17, 2020
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl zhouqiang-cl merged commit 7a37917 into chaos-mesh:master Feb 17, 2020
@YangKeao YangKeao deleted the specify-target branch August 3, 2020 03:43
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
* specify target

Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants