Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test on chaosfs #275

Merged
merged 14 commits into from Feb 24, 2020
Merged

Add unit test on chaosfs #275

merged 14 commits into from Feb 24, 2020

Conversation

lucklove
Copy link
Contributor

What problem does this PR solve?

Add unit test

What is changed and how does it work?

Add unit test

Check List

Tests

  • Unit test

Code changes

  • Has Go code change

Side effects

Related changes

Does this PR introduce a user-facing change?:

NONE

lucklove and others added 14 commits February 19, 2020 17:33
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@03ebf04). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #275   +/-   ##
=========================================
  Coverage          ?   60.38%           
=========================================
  Files             ?       36           
  Lines             ?     1941           
  Branches          ?        0           
=========================================
  Hits              ?     1172           
  Misses            ?      678           
  Partials          ?       91

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03ebf04...3f35828. Read the comment docs.

Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0 cwen0 added this to Review in progress in Weekly Plan 2020-02-22 ~ 2020-02-29 Feb 24, 2020
Weekly Plan 2020-02-22 ~ 2020-02-29 automation moved this from Review in progress to Reviewer approved Feb 24, 2020
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0 cwen0 merged commit 7ce47e8 into chaos-mesh:master Feb 24, 2020
Weekly Plan 2020-02-22 ~ 2020-02-29 automation moved this from Reviewer approved to Done Feb 24, 2020
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants