Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix event recorder name #298

Merged
merged 2 commits into from Feb 29, 2020
Merged

Fix event recorder name #298

merged 2 commits into from Feb 29, 2020

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Feb 28, 2020

Signed-off-by: yeya24 yb532204897@gmail.com

What problem does this PR solve?

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

@yeya24
fix event recorder name
4f8f186 
Signed-off-by: yeya24 <yb532204897@gmail.com>
zhouqiang-cl
zhouqiang-cl approved these changes Feb 29, 2020
View reviewed changes
Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cwen0
cwen0 approved these changes Feb 29, 2020
View reviewed changes
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl
Copy link
Contributor

/merge

@cwen0
Copy link
Member

cwen0 commented Feb 29, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Feb 29, 2020

/run-all-tests

@codecov-io
Copy link

Codecov Report

Merging #298 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #298   +/-   ##
=======================================
  Coverage   60.86%   60.86%           
=======================================
  Files          40       40           
  Lines        2484     2484           
=======================================
  Hits         1512     1512           
  Misses        872      872           
  Partials      100      100

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f8f186...e1ad233. Read the comment docs.

@sre-bot sre-bot merged commit 4f0d7db into chaos-mesh:master Feb 29, 2020
@yeya24 yeya24 deleted the fix-event-recorder-name branch March 2, 2020 02:18
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
@yeya24
Fix event recorder name (chaos-mesh#298)
b30410a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AngleNet AngleNet AngleNet approved these changes

@cwen0 cwen0 cwen0 approved these changes

@zhouqiang-cl zhouqiang-cl zhouqiang-cl approved these changes

Assignees
No one assigned
Labels
status/can-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yeya24 @zhouqiang-cl @cwen0 @sre-bot @codecov-io @AngleNet