Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable bpfki by default #318

Merged
merged 1 commit into from Mar 7, 2020
Merged

Disable bpfki by default #318

merged 1 commit into from Mar 7, 2020

Conversation

cwen0
Copy link
Member

@cwen0 cwen0 commented Mar 7, 2020

What problem does this PR solve?

diable bpfki by default

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

@codecov-io
Copy link

Codecov Report

Merging #318 into master will increase coverage by 2.94%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
+ Coverage   56.29%   59.23%   +2.94%     
==========================================
  Files          44       42       -2     
  Lines        2702     2556     -146     
==========================================
- Hits         1521     1514       -7     
+ Misses       1080      942     -138     
+ Partials      101      100       -1
Impacted Files Coverage Δ
pkg/utils/chaosdaemon.go
controllers/timechaos/types.go
pkg/utils/selector.go 53.36% <0%> (+0.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0b91a3...ea48845. Read the comment docs.

Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwen0
Copy link
Member Author

cwen0 commented Mar 7, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 7, 2020

/run-all-tests

@sre-bot sre-bot merged commit 517f694 into chaos-mesh:master Mar 7, 2020
@cwen0 cwen0 deleted the close_bpfki branch March 7, 2020 09:32
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants