Support multiple containers and multiple processes for time chaos #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Codecov Report
@@ Coverage Diff @@
## master #325 +/- ##
=======================================
Coverage 58.75% 58.75%
=======================================
Files 51 51
Lines 2849 2849
=======================================
Hits 1674 1674
Misses 1057 1057
Partials 118 118Continue to review full report at Codecov.
|
YangKeao
commented
Mar 9, 2020
| @@ -128,15 +128,30 @@ tidy: | |||
| GO111MODULE=on go mod tidy | |||
| git diff --quiet go.mod go.sum | |||
|
|
|||
| image: | |||
| image: image-chaos-daemon image-chaos-mesh image-chaos-fs image-chaos-scripts image-chaos-grafana image-chaos-dashboard image-chaos-kernel | |||
There was a problem hiding this comment.
I made this change because building chaos-kernel image is too slow (on my minikube virtual machine).
There was a problem hiding this comment.
Do we need to change CI scripts?
There was a problem hiding this comment.
No. I only split image into multiple subtasks, so there is no need to change CI scripts.
cwen0
reviewed
Mar 10, 2020
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
cwen0
reviewed
Mar 10, 2020
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
YangKeao
changed the title
YangKeao
commented
Mar 10, 2020
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
YangKeao
changed the title
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
cwen0
reviewed
Mar 11, 2020
pkg/chaosdaemon/util.go
Outdated
|
|
||
| reader, err := os.Open(statusPath) | ||
| if err != nil { | ||
| log.Info("read status file error", "path", statusPath) |
| allPids := append(childPids, pid) | ||
| log.Info("all related processes found", "pids", allPids) | ||
|
|
||
| for _, pid := range allPids { |
There was a problem hiding this comment.
What if the child process disappeared at this time?
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support multiple containers and multiple processes for time chaos.
What is changed and how does it work?
Check List
Tests
Code changes