Fix typo and update doc #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
==========================================
+ Coverage 60.40% 61.00% +0.60%
==========================================
Files 36 56 +20
Lines 1985 3347 +1362
==========================================
+ Hits 1199 2042 +843
- Misses 692 1145 +453
- Partials 94 160 +66
Continue to review full report at Codecov.
|
YangKeao
reviewed
Mar 19, 2020
helm/chaos-mesh/values.yaml
Outdated
| @@ -70,6 +70,18 @@ chaosDaemon: | |||
| # runtime: containerd | |||
| # socketPath: /run/containerd/containerd.sock | |||
|
|
|||
| resources: | |||
There was a problem hiding this comment.
Should we remove these resource limits rather than add them for all? @cwen0
There was a problem hiding this comment.
I agree with you. I think resources:{} is OK.
fewdan
reviewed
Mar 19, 2020
|
/merge |
|
/run-all-tests |
vincent178
pushed a commit
to vincent178/chaos-mesh
that referenced
this pull request
Mar 23, 2020
sjwsl
pushed a commit
to sjwsl/chaos-mesh
that referenced
this pull request
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix typo for Unit test
Update doc for helm
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: