Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong filename of .dockerignore #388

Merged
merged 2 commits into from Mar 28, 2020
Merged

Conversation

yujunz
Copy link
Contributor

@yujunz yujunz commented Mar 28, 2020

What problem does this PR solve?

Wrong filename of .dockerignore

What is changed and how does it work?

Correct filename

Check List

Tests

  • Manual test (add detailed scripts or steps below)

make image-chaos-dashboard

Code changes

  • Has CI related scripts change

Side effects

  • N/A

Related changes

  • N/A

Does this PR introduce a user-facing change?:

NONE

Copy link
Contributor

@zhouqiang-cl zhouqiang-cl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhouqiang-cl
Copy link
Contributor

/test

@codecov-io
Copy link

Codecov Report

Merging #388 into master will decrease coverage by 1.82%.
The diff coverage is 50.26%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #388      +/-   ##
==========================================
- Coverage   60.40%   58.57%   -1.83%     
==========================================
  Files          36       60      +24     
  Lines        1985     3626    +1641     
==========================================
+ Hits         1199     2124     +925     
- Misses        692     1333     +641     
- Partials       94      169      +75     
Impacted Files Coverage Δ
api/v1alpha1/podchaos_types.go 32.55% <ø> (ø)
api/v1alpha1/timechaos_types.go 4.34% <0.00%> (-0.31%) ⬇️
controllers/kernelchaos_controller.go 0.00% <0.00%> (ø)
pkg/chaosdaemon/netlink_linux.go 0.00% <0.00%> (ø)
pkg/chaosdaemon/server.go 44.44% <0.00%> (ø)
pkg/ptrace/ptrace_linux.go 65.92% <ø> (ø)
pkg/utils/coalescer.go 0.00% <0.00%> (ø)
pkg/utils/graph.go 0.00% <0.00%> (ø)
pkg/utils/grpc.go 0.00% <0.00%> (ø)
api/v1alpha1/kernelchaos_types.go 4.65% <4.65%> (ø)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0bfd44...c395122. Read the comment docs.

Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YangKeao
Copy link
Member

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Mar 28, 2020

/run-all-tests

@sre-bot sre-bot merged commit ac868d8 into chaos-mesh:master Mar 28, 2020
@yujunz yujunz deleted the dockerignore branch March 28, 2020 12:20
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants