Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use helm template instead of --dry-run #506

Merged
merged 1 commit into from
May 13, 2020
Merged

Conversation

cwen0
Copy link
Member

@cwen0 cwen0 commented May 13, 2020

Signed-off-by: cwen0 cwenyin0@gmail.com

What problem does this PR solve?

Use helm template instead of --dry-run to update install.sh, So we can run make update-install-script without the Kubernetes cluster environment.

Signed-off-by: cwen0 <cwenyin0@gmail.com>
@cwen0 cwen0 mentioned this pull request May 13, 2020
@cwen0 cwen0 changed the title use helm template update --dry-run use helm template instead of --dry-run May 13, 2020
@cwen0
Copy link
Member Author

cwen0 commented May 13, 2020

/run-e2e-test

@cwen0 cwen0 added this to PR in Release v1.0.0 May 13, 2020
Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fewdan fewdan merged commit 368f736 into chaos-mesh:master May 13, 2020
Release v1.0.0 automation moved this from PR to PR Done May 13, 2020
@cwen0 cwen0 deleted the use_template branch May 13, 2020 07:25
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Signed-off-by: cwen0 <cwenyin0@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Release v1.0.0
  
PR Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants