Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protected namespaces #661

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Protected namespaces #661

merged 1 commit into from
Jun 30, 2020

Conversation

Gallardot
Copy link
Member

What problem does this PR solve?

#414

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to update the documentation

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: Gallardot <tttick@163.com>
@CLAassistant
Copy link

CLAassistant commented Jun 29, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #661 into master will decrease coverage by 0.08%.
The diff coverage is 48.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #661      +/-   ##
==========================================
- Coverage   55.78%   55.69%   -0.09%     
==========================================
  Files          68       67       -1     
  Lines        4383     4417      +34     
==========================================
+ Hits         2445     2460      +15     
- Misses       1768     1782      +14     
- Partials      170      175       +5     
Impacted Files Coverage Δ
controllers/networkchaos/ipset/ipset.go 37.14% <0.00%> (ø)
pkg/store/experiment/experiment.go 32.20% <0.00%> (-6.58%) ⬇️
pkg/utils/chaosdaemon.go 51.21% <0.00%> (ø)
pkg/utils/grpc.go 0.00% <0.00%> (ø)
pkg/webhook/inject/inject.go 73.49% <0.00%> (-0.68%) ⬇️
controllers/twophase/types.go 54.20% <40.00%> (-1.68%) ⬇️
controllers/networkchaos/netem/types.go 47.27% <50.00%> (ø)
pkg/utils/selector.go 53.15% <66.66%> (+0.91%) ⬆️
controllers/podchaos/containerkill/types.go 64.38% <100.00%> (ø)
controllers/timechaos/types.go 61.44% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 699993e...f4ac05a. Read the comment docs.

Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. Just curious about the design, do we only need one regex instead of a list of regex?

@Gallardot
Copy link
Member Author

The code looks good. Just curious about the design, do we only need one regex instead of a list of regex?

@yeya24 I think one regular expression is enough.

For example, you want chaos tasks to be performed on a namespace with either the DEV- prefix or the TEST- suffix. The allowedNamespaces can be set to TEST-\w+|\w+-DEV.

Copy link
Member

@fewdan fewdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Gallardot
Copy link
Member Author

/merge

1 similar comment
@zhouqiang-cl
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit fcf0ac8 into chaos-mesh:master Jun 30, 2020
@Gallardot Gallardot deleted the pn branch June 30, 2020 09:45
lilin90 pushed a commit to lilin90/chaos-mesh that referenced this pull request Jul 1, 2020
Signed-off-by: Gallardot <tttick@163.com>Signed-off-by: lilin90 <lilin@pingcap.com>
shonge pushed a commit to shonge/chaos-mesh that referenced this pull request Jul 7, 2020
Signed-off-by: Gallardot <tttick@163.com>
Signed-off-by: shonge <soog2008@hotmail.com>
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
Signed-off-by: Gallardot <tttick@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants