-
Notifications
You must be signed in to change notification settings - Fork 816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protected namespaces #661
Protected namespaces #661
Conversation
Signed-off-by: Gallardot <tttick@163.com>
Codecov Report
@@ Coverage Diff @@
## master #661 +/- ##
==========================================
- Coverage 55.78% 55.69% -0.09%
==========================================
Files 68 67 -1
Lines 4383 4417 +34
==========================================
+ Hits 2445 2460 +15
- Misses 1768 1782 +14
- Partials 170 175 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. Just curious about the design, do we only need one regex instead of a list of regex?
@yeya24 I think one regular expression is enough. For example, you want chaos tasks to be performed on a namespace with either the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
1 similar comment
/merge |
/run-all-tests |
Signed-off-by: Gallardot <tttick@163.com>Signed-off-by: lilin90 <lilin@pingcap.com>
Signed-off-by: Gallardot <tttick@163.com> Signed-off-by: shonge <soog2008@hotmail.com>
Signed-off-by: Gallardot <tttick@163.com>
What problem does this PR solve?
#414
What is changed and how does it work?
Check List
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?: