Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support container-wise StressChaos injection #759

Merged
merged 6 commits into from
Jul 30, 2020

Conversation

YangKeao
Copy link
Member

Signed-off-by: Yang Keao keao.yang@yahoo.com

What problem does this PR solve?

Fix #755

Support container wise injection and run stress-ng in container's cgroup in default.

What is changed and how does it work?

Check List

Tests

  • Manual test

Code changes

  • Has Go code change

Signed-off-by: Yang Keao <keao.yang@yahoo.com>
@YangKeao YangKeao requested review from AngleNet and cwen0 July 30, 2020 09:13
@cwen0
Copy link
Member

cwen0 commented Jul 30, 2020

@fewdan @g1eny0ung Remember to update the chaos-dashboard after emerging this pr

@cwen0 cwen0 added this to In progress in Chaos Mesh Dashboard via automation Jul 30, 2020
@cwen0 cwen0 moved this from In progress to To do in Chaos Mesh Dashboard Jul 30, 2020
Signed-off-by: Yang Keao <keao.yang@yahoo.com>
cwen0
cwen0 previously approved these changes Jul 30, 2020
Copy link
Member

@cwen0 cwen0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -34,6 +34,8 @@ spec:
spec:
description: Spec defines the behavior of a time chaos experiment
properties:
containerName:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a description ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK! 🍻

@AngleNet
Copy link
Contributor

LGTM

@zhouqiang-cl
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@YangKeao merge failed.

@zhouqiang-cl
Copy link
Contributor

/run-e2e-tests

@zhouqiang-cl zhouqiang-cl merged commit 4f084d2 into chaos-mesh:master Jul 30, 2020
Chaos Mesh Dashboard automation moved this from To do to Done Jul 30, 2020
@YangKeao YangKeao deleted the stress-chaos-fix branch August 3, 2020 03:43
sjwsl pushed a commit to sjwsl/chaos-mesh that referenced this pull request May 6, 2021
* support container-wise injection

Signed-off-by: Yang Keao <keao.yang@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

The stress-burn-cpu seems not working
5 participants