[update] add container-wise StressChaos in dashboard #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #794 +/- ##
==========================================
- Coverage 55.78% 53.81% -1.98%
==========================================
Files 68 71 +3
Lines 4383 4776 +393
==========================================
+ Hits 2445 2570 +125
- Misses 1768 2002 +234
- Partials 170 204 +34
Continue to review full report at Codecov.
|
cwen0
reviewed
Aug 10, 2020
| @@ -342,6 +342,10 @@ func (s *Service) createStressChaos(exp *core.ExperimentInfo) error { | |||
| chaos.Spec.Duration = &exp.Scheduler.Duration | |||
| } | |||
|
|
|||
| if exp.Target.StressChaos.ContainerName != nil { | |||
There was a problem hiding this comment.
Do we need to check if exp.Target.StressChaos is nil?
There was a problem hiding this comment.
Seems all Create Experiment APIs should need to be checked since all ChaosInfos are pointers. 😢
We can plan a refactor for our server APIs.
Signed-off-by: Yue Yang <g1enyy0ung@gmail.com>
|
@cwen0 The dashboard has already followed the changes, PTAL. |
g1eny0ung
approved these changes
Aug 11, 2020
ti-srebot
approved these changes
Aug 11, 2020
|
/merge |
|
/run-all-tests |
|
@fewdan merge failed. |
|
/merge |
|
/run-all-tests |
sjwsl
pushed a commit
to sjwsl/chaos-mesh
that referenced
this pull request
May 6, 2021
* update Signed-off-by: “fewdan” <fewdan@hotmail.com> * chore: add stress container_name in dashboard Signed-off-by: Yue Yang <g1enyy0ung@gmail.com> Co-authored-by: Yue Yang <g1enyy0ung@gmail.com> Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: “fewdan” fewdan@hotmail.com
What problem does this PR solve?
After #759 merged, the container name was added to the StressChaos.
This PR adds container name to the dashboard
What is changed and how does it work?
add container-wise StressChaos in dashboard
Tests
Code changes
Side effects
Related changes
Does this PR introduce a user-facing change?