Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teams/tidb: a vote for D3Hunter as TiDB committer #761

Merged
merged 4 commits into from
Jun 13, 2023
Merged

teams/tidb: a vote for D3Hunter as TiDB committer #761

merged 4 commits into from
Jun 13, 2023

Conversation

lance6716
Copy link
Contributor

No description provided.

@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 6, 2023
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 6, 2023
@lance6716 lance6716 requested a review from a team as a code owner June 6, 2023 08:13
@lance6716 lance6716 changed the title [WIP]teams/tidb: a vote for D3Hunter as TiDB commiter teams/tidb: a vote for D3Hunter as TiDB commiter Jun 6, 2023
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 6, 2023
@lance6716
Copy link
Contributor Author

/hold

for 7 days

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: disksing
Once this PR has been reviewed and has the lgtm label, please assign zhangyangyu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the lgtm label Jun 13, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 13, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-07 05:08:41.064650481 +0000 UTC m=+67612.909285069: ☑️ agreed by disksing.
  • 2023-06-13 06:20:10.615905709 +0000 UTC m=+66607.030509788: ✖️🔁 reset by lance6716.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 13, 2023

New changes are detected. LGTM label has been removed.

@lance6716
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2023
@lance6716
Copy link
Contributor Author

ptal @zhangyangyu

@zhangyangyu zhangyangyu merged commit f9a8c0b into master Jun 13, 2023
1 of 2 checks passed
@zhangyangyu zhangyangyu deleted the lance6716-patch-3 branch June 13, 2023 06:45
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: cannot checkout size/S: error checking out size/S: exit status 1. output: error: pathspec 'size/S' did not match any file(s) known to git

@zhangyangyu zhangyangyu mentioned this pull request Jun 13, 2023
Merged
12 tasks
@lance6716 lance6716 changed the title teams/tidb: a vote for D3Hunter as TiDB commiter teams/tidb: a vote for D3Hunter as TiDB reviewer Jun 13, 2023
@lance6716 lance6716 changed the title teams/tidb: a vote for D3Hunter as TiDB reviewer teams/tidb: a vote for D3Hunter as TiDB committer Jun 13, 2023
lance6716 added a commit that referenced this pull request Jun 13, 2023
@lance6716
fix wrong group in #761
c7a751d
@lance6716 lance6716 mentioned this pull request Jun 13, 2023
Merged
zhangyangyu pushed a commit that referenced this pull request Jun 13, 2023
@lance6716
fix wrong group in #761 (#764)
f46a911
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing approved these changes

@zhangyangyu zhangyangyu Awaiting requested review from zhangyangyu zhangyangyu is a code owner

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lance6716 @ti-chi-bot @disksing @zhangyangyu