Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teams/tidb: a vote for ywqzzy as TiDB commiter #778

Merged
merged 1 commit into from
Jan 11, 2024
Merged

teams/tidb: a vote for ywqzzy as TiDB commiter #778

merged 1 commit into from
Jan 11, 2024

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Jan 5, 2024

As stated in the title.

@zimulala zimulala requested review from a team and zhangyangyu as code owners January 5, 2024 08:15
@ti-chi-bot ti-chi-bot bot requested a review from kennytm January 5, 2024 08:15
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 5, 2024
@zhangyangyu zhangyangyu added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 5, 2024
Benjamin2037
Benjamin2037 approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@Benjamin2037 Benjamin2037 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 8, 2024

@Benjamin2037: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 8, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-08 06:59:25.180937791 +0000 UTC m=+253754.765191477: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 11, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Benjamin2037, disksing, lance6716, tangenta
Once this PR has been reviewed and has the lgtm label, please assign zhangyangyu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhangyangyu zhangyangyu merged commit 823e584 into pingcap:master Jan 11, 2024
1 check passed
@zimulala zimulala deleted the zimuxia/vote branch January 12, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lance6716 lance6716 lance6716 approved these changes

@disksing disksing disksing approved these changes

@Benjamin2037 Benjamin2037 Benjamin2037 approved these changes

@tangenta tangenta tangenta approved these changes

@zhangyangyu zhangyangyu Awaiting requested review from zhangyangyu zhangyangyu is a code owner

@kennytm kennytm Awaiting requested review from kennytm

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@zimulala @lance6716 @disksing @Benjamin2037 @tangenta @zhangyangyu