promote xzhangxian1008 as TiDB reviewer #779
Conversation
ti-chi-bot
bot
added
the
size/S
|
@guo-shaoge: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
+1 |
|
+1 |
|
@SeaRise: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
+1 |
|
|
||
| The ongoing work has demonstrated noteworthy progress, showcasing his substantial engineering expertise. You can find a comprehensive list of his contributions, including authored commits, [here](https://github.com/pingcap/tidb/commits?author=xzhangxian1008). | ||
|
|
||
| I, [@XuHuaiyu](https://github.com/xzhangxian1008), strongly endorse @xzhangxian1008 for the position of TiDB Reviewer and urge your support through a vote. |
There was a problem hiding this comment.
| I, [@XuHuaiyu](https://github.com/xzhangxian1008), strongly endorse @xzhangxian1008 for the position of TiDB Reviewer and urge your support through a vote. | |
| I, [@XuHuaiyu](https://github.com/XuHuaiyu), strongly endorse @xzhangxian1008 for the position of TiDB Reviewer and urge your support through a vote. |
|
+1 Congrats! |
|
/approve |
|
/hold |
ti-chi-bot
bot
added
the
do-not-merge/hold
|
@XuHuaiyu please update the team json file. |
|
New changes are detected. LGTM label has been removed. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bb7133, guo-shaoge, SeaRise, zhangyangyu, zimulala The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As the title says