support dbt v1.2 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
shiyuhang0
force-pushed
the
dbt_1.2
branch
6 times, most recently
from
6d07b6b
to
bc039a1
Compare
shiyuhang0
changed the title
shiyuhang0
force-pushed
the
dbt_1.2
branch
9 times, most recently
from
5dcd7b2
to
bbad2c1
Compare
shiyuhang0
force-pushed
the
dbt_1.2
branch
7 times, most recently
from
f79b23b
to
a8ea83c
Compare
zhangyangyu
reviewed
Aug 18, 2022
zhangyangyu
reviewed
Aug 18, 2022
zhangyangyu
approved these changes
Aug 18, 2022
zhangyangyu
reviewed
Aug 19, 2022
dbt/include/tidb/macros/materializations/incremental/helpers.sql
Outdated
Show resolved
Hide resolved
zhangyangyu
reviewed
Aug 19, 2022
dbt/include/tidb/macros/materializations/incremental/incremental.sql
Outdated
Show resolved
Hide resolved
zhangyangyu
reviewed
Aug 19, 2022
|
resolve the conflicts after #13 merged |
zhangyangyu
approved these changes
Aug 20, 2022
# Conflicts: # .github/workflows/main.yml # README.md # dbt/adapters/tidb/connections.py # dbt/include/tidb/macros/materializations/snapshot/strategies.sql # requirements_dev.txt # setup.py # tests/README.md # tests/conftest.py # tests/functional/adapter/tidb/basic/test_tidb.py # tests/functional/adapter/tidb4_0/basic/test_tidb.py # tests/functional/adapter/tidb5_1/basic/test_tidb.py
dataders
reviewed
Aug 23, 2022
| @@ -6,26 +6,41 @@ | |||
| {%- endfor -%})) | |||
| {%- endmacro %} | |||
|
|
|||
| {% macro snapshot_check_all_get_existing_columns(node, target_exists) -%} | |||
| {%- set query_columns = get_columns_in_query(node['compiled_sql']) -%} | |||
| -- copy from dbt-core v1.2, just alter database=None in adapter.get_relation | |||
There was a problem hiding this comment.
@shiyuhang0 what if a relation object never printed the database? would save you from having to override core's version of this macro?
There was a problem hiding this comment.
I think maybe we can delete this override because I found that the database has been set to None in get_relation.
And I will test if it still works after delete the macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #2
What is changed and how it works?
Check List