Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add quote to column in create_table_as marco #9

Merged
merged 1 commit into from
Aug 11, 2022

Conversation

Daemonxiao
Copy link
Contributor

What problem does this PR solve?

If we don't add quotes, we will make some mistakes in particular column names.
Such as "3jfio32 834", "@ivjo efji" and so on.

This is a wrong SQL sample without a quote.

create table t (fhii 34JIo@ char);

To correct it, just add a quote.

create table t (`fhii 34JIo@` char);

Check List

  • [] unit test
  • integration test
  • modify doc
  • change source code

@sre-bot
Copy link

sre-bot commented Aug 10, 2022

CLA assistant check
All committers have signed the CLA.

@Daemonxiao Daemonxiao merged commit 77bfd31 into pingcap:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants