Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support django v4.2.1 #37

Merged
merged 7 commits into from
Jul 22, 2023
Merged

feat: support django v4.2.1 #37

merged 7 commits into from
Jul 22, 2023

Conversation

wd0517
Copy link
Collaborator

@wd0517 wd0517 commented Jul 20, 2023 •
edited

Feature

  • Add column_comment when introspecting table schema

Fix

  • TiDB doesn't support defaults for BLOB/TEXT/JSON in the ALTER COLUMN statement.
  • Django 4.2.1 no longer supports MySQL 5.7, we need to explicitly declare the tidb_version in get_database_version
  • Remove hard code in tidb_settings.py

@sre-bot
Copy link

sre-bot commented Jul 20, 2023 •
edited

CLA assistant check
All committers have signed the CLA.

dveeden
dveeden approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@dveeden dveeden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to update .github/workflows/ci.yaml to also test with v4.2

I would suggest to extend the django4_tidb5 with a test matrix that includes v4.1.7 and v4.2.1.

@wd0517
Copy link
Collaborator Author

wd0517 commented Jul 22, 2023

Would be good to update .github/workflows/ci.yaml to also test with v4.2

I will create a new pr to update ci, not only django v4.2, also add tidb v6 & v7, follow the tidb release support policy

@wd0517 wd0517 merged commit 04a7223 into pingcap:main Jul 22, 2023
18 checks passed
@wd0517 wd0517 deleted the feat/django-4.2.1 branch July 22, 2023 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dveeden dveeden dveeden approved these changes

@zhangyangyu zhangyangyu zhangyangyu approved these changes

@hawkingrei hawkingrei Awaiting requested review from hawkingrei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wd0517 @sre-bot @dveeden @zhangyangyu