Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

add task source-id length check #141

Closed
amyangfei opened this issue May 9, 2019 · 1 comment
Closed

add task source-id length check #141

amyangfei opened this issue May 9, 2019 · 1 comment
Assignees
Labels
type/feature-request This issue is a feature request

Comments

@amyangfei
Copy link
Contributor

Feature Request

Is your feature request related to a problem? Please describe:

The id field in loader/syncer unit checkpoint table is char(32)/varchar(32), as source-id is defined by user without any length restriction, this may lead to error initialize checkpoint: Error 1406: Data too long for column 'id' at row 1

Describe the feature you'd like:

add source-id length check in check-task, and find out whether more restrictions should be added.

@amyangfei amyangfei added the type/feature-request This issue is a feature request label May 9, 2019
@amyangfei amyangfei self-assigned this May 9, 2019
@csuzhangxc
Copy link
Member

I think we should also do the check in DM-ansible and DM-worker.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type/feature-request This issue is a feature request
Projects
None yet
Development

No branches or pull requests

2 participants