Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

pkg/parser: fix the typo #138

Closed
wants to merge 2 commits into from
Closed

pkg/parser: fix the typo #138

wants to merge 2 commits into from

Conversation

hoobean1996
Copy link

comment_test.go -> common_test.go

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the dm/dm-ansible
  • Need to be included in the release note

comment_test.go -> common_test.go
@CLAassistant
Copy link

CLAassistant commented May 7, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ hoobean1996
❌ bin.he


bin.he seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
please sign the CLA.

@csuzhangxc csuzhangxc added priority/unimportant Really minor change, requires approval from secondary reviewers status/LGT1 One reviewer already commented LGTM labels May 7, 2019
@csuzhangxc
Copy link
Member

@amyangfei PTAL

Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added type/qa relate to quality assurance status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels May 7, 2019
@csuzhangxc
Copy link
Member

@hoobean1996 you have used a user name bin.he to commit with e347fd6, but bin.he seems not to be a GitHub user.

@hoobean1996
Copy link
Author

sorry, I've used wrong account - -

@hoobean1996 hoobean1996 closed this May 8, 2019
@suzaku suzaku mentioned this pull request May 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/unimportant Really minor change, requires approval from secondary reviewers status/LGT2 Two reviewers already commented LGTM, ready for merge type/qa relate to quality assurance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants