Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

relay: begin with the latest binlog file if relay position is not set (#304) #318

Merged
merged 11 commits into from Oct 17, 2019
Merged

relay: begin with the latest binlog file if relay position is not set (#304) #318

merged 11 commits into from Oct 17, 2019

Conversation

sre-bot
Copy link

@sre-bot sre-bot commented Oct 17, 2019

cherry-pick #304 to release-1.0

What problem does this PR solve?

relay begin with the latest binlog file if relay position is not set

What is changed and how it works?

Check List

Tests

  • Manual test (don't set relay log's config, and check the binlog file's start name under relay log's dir)

Related changes

  • Need to cherry-pick to the release branch

@sre-bot sre-bot mentioned this pull request Oct 17, 2019
Merged
@sre-bot sre-bot added priority/normal Minor change, requires approval from ≥1 primary reviewer priority/release-blocker This PR blocks a release. Please review it ASAP. needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated type/cherry-pick This PR is just a cherry-pick (backport) type/enhancement Performance improvement or refactoring labels Oct 17, 2019
amyangfei
amyangfei reviewed Oct 17, 2019
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added the status/LGT1 One reviewer already commented LGTM label Oct 17, 2019
@codecov
Copy link

codecov bot commented Oct 17, 2019

Codecov Report

❗ No coverage uploaded for pull request base (release-1.0@ab13ec3). Click here to learn what that means.
The diff coverage is 75.7575%.

@@               Coverage Diff                @@
##             release-1.0       #318   +/-   ##
================================================
  Coverage               ?   60.6902%           
================================================
  Files                  ?        134           
  Lines                  ?      14836           
  Branches               ?          0           
================================================
  Hits                   ?       9004           
  Misses                 ?       4964           
  Partials               ?        868

csuzhangxc
csuzhangxc approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Oct 17, 2019
@WangXiangUSTC WangXiangUSTC merged commit b36357e into pingcap:release-1.0 Oct 17, 2019
@csuzhangxc csuzhangxc added already-update-docs The docs related to this PR already updated. Add this label once the docs are updated and removed needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated labels Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amyangfei amyangfei amyangfei left review comments

@csuzhangxc csuzhangxc csuzhangxc approved these changes

Assignees
No one assigned
Labels
already-update-docs The docs related to this PR already updated. Add this label once the docs are updated priority/normal Minor change, requires approval from ≥1 primary reviewer priority/release-blocker This PR blocks a release. Please review it ASAP. status/LGT2 Two reviewers already commented LGTM, ready for merge type/cherry-pick This PR is just a cherry-pick (backport) type/enhancement Performance improvement or refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sre-bot @amyangfei @csuzhangxc @WangXiangUSTC