Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: only retry for special message with 1105 (#330) #332

Merged
merged 2 commits into from
Oct 23, 2019
Merged

*: only retry for special message with 1105 (#330) #332

merged 2 commits into from
Oct 23, 2019

Conversation

sre-bot
Copy link

@sre-bot sre-bot commented Oct 23, 2019

cherry-pick #330 to release-1.0

What problem does this PR solve?

1105 means an unknown error in MySQL/TiDB. some of these errors are retryable, but some are not (like error="Error 1105: statement count 5001 exceeds the transaction limitation).

What is changed and how it works?

only retry for retryable errors, now including:

  • Information schema is out of date
  • Information schema is changed

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch
  • Need to be included in the release note

@sre-bot sre-bot mentioned this pull request Oct 23, 2019
Merged
@sre-bot sre-bot added priority/normal Minor change, requires approval from ≥1 primary reviewer needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Oct 23, 2019
@csuzhangxc
Copy link
Member

/run-all-tests

@codecov
Copy link

codecov bot commented Oct 23, 2019

Codecov Report

❗ No coverage uploaded for pull request base (release-1.0@bad74fa). Click here to learn what that means.
The diff coverage is 0%.

@@               Coverage Diff                @@
##             release-1.0       #332   +/-   ##
================================================
  Coverage               ?   59.8898%           
================================================
  Files                  ?        135           
  Lines                  ?      15076           
  Branches               ?          0           
================================================
  Hits                   ?       9029           
  Misses                 ?       5167           
  Partials               ?        880

WangXiangUSTC
WangXiangUSTC reviewed Oct 23, 2019
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added the status/LGT1 One reviewer already commented LGTM label Oct 23, 2019
amyangfei
amyangfei approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@amyangfei amyangfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@amyangfei amyangfei added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Oct 23, 2019
@amyangfei amyangfei merged commit 35289ee into pingcap:release-1.0 Oct 23, 2019
@csuzhangxc csuzhangxc added already-update-release-note The release note is updated. Add this label once the release note is updated and removed needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Nov 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@WangXiangUSTC WangXiangUSTC WangXiangUSTC left review comments

@amyangfei amyangfei amyangfei approved these changes

Assignees
No one assigned
Labels
already-update-release-note The release note is updated. Add this label once the release note is updated priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sre-bot @csuzhangxc @amyangfei @WangXiangUSTC