Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: refine dashboard #591

Closed
wants to merge 2 commits into from
Closed

*: refine dashboard #591

wants to merge 2 commits into from

Conversation

csuzhangxc
Copy link
Member

@csuzhangxc csuzhangxc commented Apr 10, 2020 •
edited

What problem does this PR solve?

  • fix plane for DML queue remain length
  • update more planes

What is changed and how it works?

  • fix plane for DML queue remain length
  • add more query (like .95, .99) for some planes

image

image

image

image

Check List

Tests

  • No code

Related changes

  • Need to update the documentation
  • Need to be included in the release note

@csuzhangxc csuzhangxc added priority/normal Minor change, requires approval from ≥1 primary reviewer needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated status/PTAL This PR is ready for review. Add this label back after committing new changes needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Apr 10, 2020
@csuzhangxc
Copy link
Member Author

@GregoryIan @lichunzhu PTAL

@codecov
Copy link

codecov bot commented Apr 10, 2020 •
edited

Codecov Report

Merging #591 into release-1.0 will decrease coverage by 0.0478%.
The diff coverage is 58.0000%.

@@                 Coverage Diff                 @@
##           release-1.0       #591        +/-   ##
===================================================
- Coverage      57.2899%   57.2420%   -0.0479%     
===================================================
  Files              161        161                
  Lines            16708      16708                
===================================================
- Hits              9572       9564         -8     
- Misses            6191       6199         +8     
  Partials           945        945

csuzhangxc added a commit to csuzhangxc/dm that referenced this pull request Apr 11, 2020
@csuzhangxc
*: copy dashboard from pingcap#591
7de3a37
@csuzhangxc
Copy link
Member Author

already done this in #594.

@csuzhangxc csuzhangxc closed this Apr 12, 2020
@csuzhangxc csuzhangxc deleted the refine-dashboard branch April 12, 2020 12:21
@csuzhangxc csuzhangxc removed needs-update-docs Should update docs after this PR is merged. Remove this label once the docs are updated needs-update-release-note This PR should be added into release notes. Remove this label once the release notes are updated labels Jun 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@csuzhangxc