Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dm-worker: move cpu metrics to worker server level (#696) #710

Merged
merged 1 commit into from Jun 4, 2020

Conversation

sre-bot
Copy link

@sre-bot sre-bot commented Jun 4, 2020

cherry-pick #696 to release-1.0


What problem does this PR solve?

Data race at collecting metrics. #672

What is changed and how it works?

move cpu usage metrics to worker server level

Tests

  • Unit test
  • Integration test

@sre-bot sre-bot added priority/normal Minor change, requires approval from ≥1 primary reviewer type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport) labels Jun 4, 2020
@GMHDBJD
Copy link
Collaborator

GMHDBJD commented Jun 4, 2020

/run-all-tests

@codecov
Copy link

codecov bot commented Jun 4, 2020

Codecov Report

Merging #710 into release-1.0 will increase coverage by 0.0343%.
The diff coverage is 65.0000%.

@@                 Coverage Diff                 @@
##           release-1.0       #710        +/-   ##
===================================================
+ Coverage      57.8408%   57.8752%   +0.0343%     
===================================================
  Files              166        166                
  Lines            16988      16990         +2     
===================================================
+ Hits              9826       9833         +7     
+ Misses            6206       6200         -6     
- Partials           956        957         +1     

Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lichunzhu lichunzhu added the status/LGT1 One reviewer already commented LGTM label Jun 4, 2020
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD merged commit 30f9cf8 into pingcap:release-1.0 Jun 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT1 One reviewer already commented LGTM type/bug-fix Bug fix type/cherry-pick This PR is just a cherry-pick (backport)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants