This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
error_message: remove stack error message #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMHDBJD
added
status/WIP
GMHDBJD
added
status/PTAL
|
Test fail because pingcap/tidb#18061 |
|
/run-all-tests tidb=v4.0.1 |
|
/run-all-tests tidb=v4.0.0 |
csuzhangxc
reviewed
Jun 17, 2020
dm/ctl/master/check_task.go
Outdated
| @@ -44,7 +44,7 @@ func checkTaskFunc(cmd *cobra.Command, _ []string) { | |||
| } | |||
| content, err := common.GetFileContent(cmd.Flags().Arg(0)) | |||
| if err != nil { | |||
| common.PrintLines("get file content error:\n%v", errors.ErrorStack(err)) | |||
| common.PrintLines("get file content error:\n%v", terror.Message(err)) | |||
There was a problem hiding this comment.
How about returning Error directly? for terror, it will contain useful code, class, etc.
|
/run-all-tests tidb=v4.0.0 |
1 similar comment
|
/run-all-tests tidb=v4.0.0 |
GMHDBJD
added
status/WIP
GMHDBJD
force-pushed
the
removeStackErrMsg
branch
from
8f7c249
to
e78ee18
Compare
|
/run-all-tests tidb=v4.0.0 |
|
/run-all-tests tidb=v4.0.0 |
GMHDBJD
added
status/PTAL
csuzhangxc
reviewed
Jun 18, 2020
csuzhangxc
reviewed
Jun 18, 2020
Co-authored-by: Xuecheng Zhang <csuzhangxc@gmail.com>
|
/run-all-tests tidb=v4.0.0 |
csuzhangxc
added
needs-update-release-note
|
/run-all-tests tidb=v4.0.0 |
Codecov Report
@@ Coverage Diff @@
## master #746 +/- ##
================================================
+ Coverage 57.0871% 57.1138% +0.0266%
================================================
Files 206 205 -1
Lines 21292 21191 -101
================================================
- Hits 12155 12103 -52
+ Misses 7951 7916 -35
+ Partials 1186 1172 -14 |
WangXiangUSTC
added
status/LGT2
|
cherry pick to release-1.0 failed |
GMHDBJD
added a commit
to GMHDBJD/dm
that referenced
this pull request
Jun 18, 2020
GMHDBJD
added a commit
that referenced
this pull request
Jun 19, 2020
csuzhangxc
added
already-cherry-pick-1.0
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
remove stack information of error message
What is changed and how it works?
Tests