Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

checkpoint: flush global checkpoint when first time flush checkpoint #758

Merged
merged 4 commits into from
Jun 28, 2020
Merged

checkpoint: flush global checkpoint when first time flush checkpoint #758

merged 4 commits into from
Jun 28, 2020

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Jun 23, 2020

What problem does this PR solve?

close #757

What is changed and how it works?

flush global checkpoint when first flush checkpoint

Check List

Tests

  • Unit test

@GMHDBJD GMHDBJD added status/PTAL This PR is ready for review. Add this label back after committing new changes type/bug-fix Bug fix labels Jun 23, 2020
@codecov
Copy link

codecov bot commented Jun 23, 2020 •
edited
Loading

Codecov Report

Merging #758 into master will increase coverage by 0.0647%.
The diff coverage is 47.8673%.

@@               Coverage Diff                @@
##             master       #758        +/-   ##
================================================
+ Coverage   57.0981%   57.1629%   +0.0647%     
================================================
  Files           205        206         +1     
  Lines         21104      21311       +207     
================================================
+ Hits          12050      12182       +132     
- Misses         7890       7940        +50     
- Partials       1164       1189        +25

@GMHDBJD GMHDBJD requested review from WangXiangUSTC and csuzhangxc and removed request for WangXiangUSTC June 23, 2020 10:40
@GMHDBJD GMHDBJD changed the title checkpoint: flush global checkpoint when first flush checkpoint checkpoint: flush global checkpoint when first time flush checkpoint Jun 23, 2020
@csuzhangxc csuzhangxc added this to In progress in Stability Improvement via automation Jun 24, 2020
csuzhangxc
csuzhangxc reviewed Jun 24, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we need to cherry-pick this to release-1.0?

rest LGTM

syncer/syncer_test.go Show resolved Hide resolved
@GMHDBJD GMHDBJD added the needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 label Jun 24, 2020
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Jun 24, 2020

@WangXiangUSTC @csuzhangxc PTAL again ~

csuzhangxc
csuzhangxc reviewed Jun 24, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jun 24, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC milestone Jun 24, 2020
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Jun 24, 2020

/run-all-tests

Stability Improvement automation moved this from In progress to Reviewer approved Jun 28, 2020
WangXiangUSTC
WangXiangUSTC approved these changes Jun 28, 2020
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jun 28, 2020
@GMHDBJD GMHDBJD merged commit 2d4fb4a into pingcap:master Jun 28, 2020
Stability Improvement automation moved this from Reviewer approved to Done Jun 28, 2020
@GMHDBJD GMHDBJD deleted the fixGlobalPoint branch June 28, 2020 03:27
@ti-srebot
Copy link

cherry pick to release-1.0 failed

@GMHDBJD GMHDBJD mentioned this pull request Jun 28, 2020
Merged
@GMHDBJD GMHDBJD mentioned this pull request Jun 28, 2020
Merged
@lance6716 lance6716 removed the needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 label Aug 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

Assignees
No one assigned
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge type/bug-fix Bug fix
Projects
Stability Improvement
  
Done
Milestone
v2.0.0 RC
Development

Successfully merging this pull request may close these issues.

restart task fail to get binlog.
5 participants
@GMHDBJD @ti-srebot @csuzhangxc @WangXiangUSTC @lance6716