This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 190
error_message: more friendly error message #771
Merged
GMHDBJD
merged 17 commits into
pingcap:master
from
GMHDBJD:replaceProcessErrorWithTError
Jul 8, 2020
Merged
error_message: more friendly error message #771
GMHDBJD
merged 17 commits into
pingcap:master
from
GMHDBJD:replaceProcessErrorWithTError
Jul 8, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
1 similar comment
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #771 +/- ##
===========================================
Coverage 57.1281% 57.1281%
===========================================
Files 206 206
Lines 21352 21352
===========================================
Hits 12198 12198
Misses 7964 7964
Partials 1190 1190 |
/run-all-tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
LGTM |
@WangXiangUSTC,Thanks for your review. |
/run-all-tests |
lance6716
reviewed
Jul 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest LGTM
Usability Improvement
automation
moved this from Review in progress
to Reviewer approved
Jul 7, 2020
lance6716
approved these changes
Jul 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-all-tests |
1 similar comment
/run-all-tests |
cherry pick to release-1.0 failed |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
already-cherry-pick-1.0
The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked
priority/normal
Minor change, requires approval from ≥1 primary reviewer
status/LGT2
Two reviewers already commented LGTM, ready for merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?