Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

dmctl: check master connection when start. #786

Merged
merged 4 commits into from
Jul 8, 2020
Merged

dmctl: check master connection when start. #786

merged 4 commits into from
Jul 8, 2020

Conversation

GMHDBJD
Copy link
Collaborator

@GMHDBJD GMHDBJD commented Jul 7, 2020

What problem does this PR solve?

close #571

What is changed and how it works?

  • add block and timeout when create masterClient in dmctl.
  • remove tests which start dmctl when master has not started.

Check List

Tests

  • Integration test

@GMHDBJD GMHDBJD added priority/normal Minor change, requires approval from ≥1 primary reviewer type/feature New feature labels Jul 7, 2020
@GMHDBJD
Copy link
Collaborator Author

GMHDBJD commented Jul 7, 2020

/run-all-tests

@GMHDBJD GMHDBJD added the status/PTAL This PR is ready for review. Add this label back after committing new changes label Jul 7, 2020
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #786 into master will increase coverage by 0.0627%.
The diff coverage is 54.2406%.

@@               Coverage Diff                @@
##             master       #786        +/-   ##
================================================
+ Coverage   57.0981%   57.1609%   +0.0627%     
================================================
  Files           205        206         +1     
  Lines         21104      21345       +241     
================================================
+ Hits          12050      12201       +151     
- Misses         7890       7958        +68     
- Partials       1164       1186        +22

lance6716
lance6716 reviewed Jul 8, 2020
View reviewed changes
Copy link
Collaborator

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

tests/dmctl_advance/run.sh Outdated Show resolved Hide resolved
tests/dmctl_command/run.sh Show resolved Hide resolved
tests/dmctl_basic/run.sh Show resolved Hide resolved
@lance6716
Copy link
Collaborator

LGTM

@ti-srebot
Copy link

@lance6716, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:tools(slack).

@lance6716 lance6716 added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Jul 8, 2020
WangXiangUSTC
WangXiangUSTC approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WangXiangUSTC WangXiangUSTC added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Jul 8, 2020
@GMHDBJD GMHDBJD merged commit ed9c483 into pingcap:master Jul 8, 2020
@GMHDBJD GMHDBJD deleted the checkConInDmctl branch July 8, 2020 07:49
@GMHDBJD GMHDBJD added the needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 label Jul 9, 2020
@ti-srebot
Copy link

cherry pick to release-1.0 failed

GMHDBJD added a commit to GMHDBJD/dm that referenced this pull request Jul 14, 2020
@GMHDBJD
dmctl: check master connection when start. (pingcap#786)
aa73492
@GMHDBJD GMHDBJD mentioned this pull request Jul 14, 2020
Merged
@csuzhangxc csuzhangxc added this to In progress in Usability Improvement via automation Jul 15, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC milestone Jul 15, 2020
GMHDBJD added a commit that referenced this pull request Jul 16, 2020
@GMHDBJD
dmctl: check master connection when start. (#786) (#802)
b4c7293
@csuzhangxc csuzhangxc moved this from In progress to Done in Usability Improvement Jul 16, 2020
@lance6716 lance6716 added already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked and removed needs-cherry-pick-release-1.0 This PR should be cherry-picked to release-1.0. Remove this label after cherry-picked to release-1.0 labels Jul 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lance6716 lance6716 lance6716 left review comments

@WangXiangUSTC WangXiangUSTC WangXiangUSTC approved these changes

Assignees
No one assigned
Labels
already-cherry-pick-1.0 The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/feature New feature
Projects
Usability Improvement
  
Done
Milestone
v2.0.0 RC
Development

Successfully merging this pull request may close these issues.

check whether the master's address can be connected before enter the dmctl's interaction moded
5 participants
@GMHDBJD @lance6716 @ti-srebot @WangXiangUSTC @csuzhangxc