Skip to content
This repository has been archived by the owner on Nov 24, 2023. It is now read-only.

*: add panel for start leader and heartbeat update error #853

Merged
merged 9 commits into from
Aug 6, 2020
Merged

*: add panel for start leader and heartbeat update error #853

merged 9 commits into from
Aug 6, 2020

Conversation

lance6716
Copy link
Collaborator

@lance6716 lance6716 commented Aug 3, 2020 •
edited
Loading

What problem does this PR solve?

close #543 , please help me check grafana and fell free to put forward more metrics

What is changed and how it works?

add panel for number of start leader and heartbeat update error

Check List

Tests

  • Manual test (check visual result)

Code changes

Side effects

Related changes

@lance6716 lance6716 added priority/normal Minor change, requires approval from ≥1 primary reviewer status/PTAL This PR is ready for review. Add this label back after committing new changes type/dm-ansible type/feature New feature labels Aug 3, 2020
GMHDBJD
GMHDBJD reviewed Aug 3, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GMHDBJD GMHDBJD added status/LGT1 One reviewer already commented LGTM and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Aug 3, 2020
@csuzhangxc
Copy link
Member

another notice, should we need to update alert rules for newly added metrics?

csuzhangxc
csuzhangxc previously approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csuzhangxc csuzhangxc added status/LGT2 Two reviewers already commented LGTM, ready for merge and removed status/LGT1 One reviewer already commented LGTM labels Aug 5, 2020
@csuzhangxc csuzhangxc added this to In progress in Usability Improvement via automation Aug 5, 2020
@csuzhangxc csuzhangxc added this to the v2.0.0 RC milestone Aug 5, 2020
@lance6716
Copy link
Collaborator Author

how to test alert (wip)

@csuzhangxc
Copy link
Member

how to test alert (wip)

I only know testing it manually by:

  • trigger defined alter rules
  • observe /alerts in Prometheus

image

@lance6716 lance6716 added the status/WIP This PR is still work in progress label Aug 5, 2020
Usability Improvement automation moved this from In progress to Review in progress Aug 5, 2020
@lance6716
Copy link
Collaborator Author

image
added some alert and test (expression of picture above is changed to see result)

csuzhangxc
csuzhangxc reviewed Aug 5, 2020
View reviewed changes
Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM again. @GMHDBJD PTAL again.

@lance6716 lance6716 removed the status/WIP This PR is still work in progress label Aug 5, 2020
@lance6716
Copy link
Collaborator Author

/run-all-tests

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

Merging #853 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master       #853   +/-   ##
===========================================
  Coverage   56.1178%   56.1178%           
===========================================
  Files           220        220           
  Lines         22647      22647           
===========================================
  Hits          12709      12709           
  Misses         8670       8670           
  Partials       1268       1268

Usability Improvement automation moved this from Review in progress to Reviewer approved Aug 6, 2020
GMHDBJD
GMHDBJD approved these changes Aug 6, 2020
View reviewed changes
Copy link
Collaborator

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716 lance6716 merged commit 0675980 into pingcap:master Aug 6, 2020
Usability Improvement automation moved this from Reviewer approved to Done Aug 6, 2020
@lance6716 lance6716 deleted the add-panel branch August 6, 2020 01:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@csuzhangxc csuzhangxc csuzhangxc left review comments

@GMHDBJD GMHDBJD GMHDBJD approved these changes

Assignees
No one assigned
Labels
priority/normal Minor change, requires approval from ≥1 primary reviewer status/LGT2 Two reviewers already commented LGTM, ready for merge type/feature New feature
Projects
Usability Improvement
  
Done
Milestone
v2.0.0 RC
Development

Successfully merging this pull request may close these issues.

HA: add and refactor metrics
3 participants
@lance6716 @csuzhangxc @GMHDBJD