This repository has been archived by the owner on Nov 24, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 190
precheck: support primary/unique key check #870
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #870 +/- ##
===========================================
Coverage 56.0502% 56.0502%
===========================================
Files 220 220
Lines 22867 22867
===========================================
Hits 12817 12817
Misses 8736 8736
Partials 1314 1314 |
LGTM |
csuzhangxc
previously approved these changes
Aug 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. BTW, can we also add PK to test data to fix cases, right?
Have added PK to test data, PTAL again. @csuzhangxc @lance6716 |
LGTM |
csuzhangxc
approved these changes
Aug 10, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Usability Improvement
automation
moved this from Review in progress
to Reviewer approved
Aug 10, 2020
cherry pick to release-1.0 failed |
GMHDBJD
added a commit
to GMHDBJD/dm
that referenced
this pull request
Aug 12, 2020
GMHDBJD
added a commit
that referenced
this pull request
Aug 13, 2020
6 tasks
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
already-cherry-pick-1.0
The related PR is already cherry-picked to release-1.0. Add this label once the PR is cherry-picked
already-update-release-note
The release note is updated. Add this label once the release note is updated
priority/normal
Minor change, requires approval from ≥1 primary reviewer
status/LGT1
One reviewer already commented LGTM
type/feature
New feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
close #788
What is changed and how it works?
update tidb-tools and fix some tests
Tests