Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

planner: update the doc for the leading hint #10331

Merged
merged 10 commits into from
Jul 26, 2022
Merged

planner: update the doc for the leading hint #10331

merged 10 commits into from
Jul 26, 2022

Conversation

Reminiscent
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 1, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn July 1, 2022 07:05
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 1, 2022
@Reminiscent
Copy link
Contributor Author

/cc @qw4990

@ti-chi-bot ti-chi-bot requested a review from qw4990 July 1, 2022 07:06
@TomShawn TomShawn self-assigned this Jul 1, 2022
@TomShawn TomShawn added area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. v6.2 This PR/issue applies to TiDB v6.2. translation/doing This PR’s assignee is translating this PR. and removed missing-translation-status This PR does not have translation status info. labels Jul 1, 2022
@shichun-0415 shichun-0415 added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2022
qw4990
qw4990 reviewed Jul 13, 2022
View reviewed changes
optimizer-hints.md Outdated Show resolved Hide resolved
@Reminiscent Reminiscent changed the title planner: update the doc for ordered_hash_join hint and leading hint planner: update the doc for the leading hint Jul 18, 2022
TomShawn
TomShawn reviewed Jul 21, 2022
View reviewed changes
optimizer-hints.md Outdated Show resolved Hide resolved
@TomShawn TomShawn removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2022
TomShawn
TomShawn reviewed Jul 21, 2022
View reviewed changes
optimizer-hints.md Outdated Show resolved Hide resolved
@TomShawn TomShawn added the status/require-change Needs the author to address comments. label Jul 21, 2022
Reminiscent and others added 2 commits July 22, 2022 10:12
@Reminiscent @TomShawn
Update optimizer-hints.md
4aaac58 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@Reminiscent @TomShawn
Update optimizer-hints.md
80948b6 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Reminiscent
Reminiscent commented Jul 22, 2022
View reviewed changes
optimizer-hints.md Outdated Show resolved Hide resolved
TomShawn
TomShawn approved these changes Jul 22, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 22, 2022
@TomShawn TomShawn removed the status/require-change Needs the author to address comments. label Jul 22, 2022
@TomShawn
Copy link
Contributor

/remove-status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 22, 2022
@TomShawn TomShawn mentioned this pull request Jul 25, 2022
Merged
12 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 25, 2022
TomShawn
TomShawn reviewed Jul 25, 2022
View reviewed changes
optimizer-hints.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt approved these changes Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ead0d27

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 26, 2022
@ti-chi-bot ti-chi-bot merged commit b9ef884 into pingcap:master Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@qw4990 qw4990 qw4990 approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

@TomShawn TomShawn

Labels
area/planner Indicates that the Issue or PR belongs to the area of SQL planner or optimizer. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v6.2 This PR/issue applies to TiDB v6.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Reminiscent @ti-chi-bot @TomShawn @qw4990 @Oreoxmt @shichun-0415