Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tiflash label settings example #10355

Merged
merged 26 commits into from
Jul 17, 2022
Merged

add tiflash label settings example #10355

merged 26 commits into from
Jul 17, 2022

Conversation

Lloyd-Pottiger
Copy link
Contributor

@Lloyd-Pottiger Lloyd-Pottiger commented Jul 4, 2022 •
edited by shichun-0415

Signed-off-by: Lloyd-Pottiger yan1579196623@gmail.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

add tiflash label settings example

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 4, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Jul 4, 2022
@ti-chi-bot ti-chi-bot requested a review from TomShawn July 4, 2022 09:39
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 4, 2022
@CLAassistant
Copy link

CLAassistant commented Jul 4, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@Lloyd-Pottiger
add tiflash label settings example
c685d09 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@Lloyd-Pottiger
Copy link
Contributor Author

/cc @JaySon-Huang @flowbehappy @WalterWj

@TomShawn TomShawn added area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. type/enhancement This issue/PR improves documentation usability or supplements document content. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. and removed missing-translation-status This PR does not have translation status info. labels Jul 4, 2022
@TomShawn TomShawn requested review from shichun-0415 and removed request for TomShawn July 4, 2022 09:51
@Lloyd-Pottiger
address comments
4775a7d 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 5, 2022
@Lloyd-Pottiger
fix typo
2942d45 
Signed-off-by: Lloyd-Pottiger <yan1579196623@gmail.com>
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 17, 2022
@Lloyd-Pottiger
Copy link
Contributor Author

@shichun-0415 thank you~ Could you please help merge this pr?

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 17, 2022
@shichun-0415
Copy link
Contributor

@Lloyd-Pottiger The original use tiflash.md has been split into several docs in #10424. Therefore, I synchronized the change in use tiflash.md to create tiflash replicas.md. Please take a look at this PR to ensure that every change is correct. Thanks.

@Lloyd-Pottiger
Copy link
Contributor Author

@Lloyd-Pottiger The original use tiflash.md has been split into several docs in #10424. Therefore, I synchronized the change in use tiflash.md to create tiflash replicas.md. Please take a look at this PR to ensure that every change is correct. Thanks.

LGTM

shichun-0415
shichun-0415 approved these changes Jul 17, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 17, 2022
@shichun-0415
Copy link
Contributor

/remove status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 17, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: a5c28f3

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 17, 2022
@ti-chi-bot ti-chi-bot merged commit 18e273b into pingcap:master Jul 17, 2022
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jul 17, 2022
@Lloyd-Pottiger @ti-chi-bot
This is an automated cherry-pick of pingcap#10355
526f029 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 17, 2022
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #10533.

ti-chi-bot added a commit that referenced this pull request Jul 17, 2022
@ti-chi-bot
add tiflash label settings example (#10355) (#10533)
eb11cd7
@Oreoxmt Oreoxmt added the translation/doing This PR’s assignee is translating this PR. label Sep 19, 2022
@shichun-0415 shichun-0415 mentioned this pull request Oct 9, 2022
Merged
14 tasks
@shichun-0415 shichun-0415 added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Oct 9, 2022
This was referenced Oct 10, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flowbehappy flowbehappy flowbehappy approved these changes

@JaySon-Huang JaySon-Huang JaySon-Huang approved these changes

@shichun-0415 shichun-0415 shichun-0415 approved these changes

@WalterWj WalterWj Awaiting requested review from WalterWj

Assignees

@shichun-0415 shichun-0415

Labels
area/bigdata Indicates that the Issue or PR belongs to the area of TiFlash, TiSpark, and OLAP. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement This issue/PR improves documentation usability or supplements document content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@Lloyd-Pottiger @ti-chi-bot @CLAassistant @JaySon-Huang @shichun-0415 @flowbehappy @TomShawn @Oreoxmt @baurine