-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tikv: add a new config server.simplify-metrics
#10665
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
tikv-configuration-file.md
Outdated
@@ -200,6 +200,11 @@ TiKV 配置文件比命令行参数支持更多的选项。你可以在 [etc/con | |||
+ 该配置项指定 TiKV 中发送 Raft 消息的缓冲区大小。如果存在消息发送不及时导致缓冲区满、消息被丢弃的情况,可以适当调大该配置项值以提升系统运行的稳定性。 | |||
+ 默认值:8192 | |||
|
|||
### `simplify-metrics` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### `simplify-metrics` | |
### `simplify-metrics` <span class="version-mark">从 v6.2.0 版本开始引入</span> |
tikv-configuration-file.md
Outdated
@@ -200,6 +200,11 @@ TiKV 配置文件比命令行参数支持更多的选项。你可以在 [etc/con | |||
+ 该配置项指定 TiKV 中发送 Raft 消息的缓冲区大小。如果存在消息发送不及时导致缓冲区满、消息被丢弃的情况,可以适当调大该配置项值以提升系统运行的稳定性。 | |||
+ 默认值:8192 | |||
|
|||
### `simplify-metrics` | |||
|
|||
+ 是否开启精简返回的 Metrics 数据。在设置为 true 时,TiKV 可以通过过滤部分无用的 Metrics 采样数据以减少每次请求返回的 Metrics 数据量。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是否支持在线修改呢?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metrics 数据是集群监控数据吗?
+ 是否开启精简返回的 Metrics 数据。在设置为 true 时,TiKV 可以通过过滤部分无用的 Metrics 采样数据以减少每次请求返回的 Metrics 数据量。 | |
+ 是否精简返回的 Metrics 数据。设置为 `true` 后,TiKV 可以通过过滤部分 Metrics 采样数据以减少每次请求返回的 Metrics 数据量。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是的
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@BusyJay PTAL |
@@ -200,6 +200,11 @@ TiKV 配置文件比命令行参数支持更多的选项。你可以在 [etc/con | |||
+ 该配置项指定 TiKV 中发送 Raft 消息的缓冲区大小。如果存在消息发送不及时导致缓冲区满、消息被丢弃的情况,可以适当调大该配置项值以提升系统运行的稳定性。 | |||
+ 默认值:8192 | |||
|
|||
### `simplify-metrics` <span class="version-mark">从 v6.2.0 版本开始引入</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps filter-metrics
is a better name. Though I don't have strong opinions.
/merge |
This pull request has been accepted and is ready to merge. Commit hash: d97bb6a
|
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions (in Chinese).
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?