Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system-variables: explain tidb_enable_concurrent_ddl #10668

Merged
merged 7 commits into from
Jul 26, 2022
Merged

system-variables: explain tidb_enable_concurrent_ddl #10668

merged 7 commits into from
Jul 26, 2022

Conversation

wjhuang2016
Copy link
Member

@wjhuang2016 wjhuang2016 commented Jul 26, 2022 •
edited

Signed-off-by: wjhuang2016 huangwenjun1997@gmail.com

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v6.2 (TiDB 6.2 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@wjhuang2016
done
65d4121 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jul 26, 2022 •
edited

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Oreoxmt
  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn July 26, 2022 06:55
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 26, 2022
TomShawn
TomShawn reviewed Jul 26, 2022
View reviewed changes
system-variables.md Outdated

> **警告：**
>
> 禁止用户私自修改该变量。
Copy link
Contributor

@TomShawn TomShawn Jul 26, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以再说下原因和后果吗？

Suggested change
> 禁止用户私自修改该变量。
> 禁止修改该变量。

TomShawn
TomShawn reviewed Jul 26, 2022
View reviewed changes
system-variables.md Outdated
- 作用域：GLOBAL
- 是否持久化到集群：是
- 默认值：`ON`
- 这个变量用于控制是否开启 TiDB 使用并发 DDL。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以稍加解释什么是并发 DDL 吗？

Suggested change
- 这个变量用于控制是否开启 TiDB 使用并发 DDL。
- 这个变量用于控制 TiDB 是否使用并发 DDL 语句。

@shichun-0415 shichun-0415 added translation/doing This PR’s assignee is translating this PR. v6.2 This PR/issue applies to TiDB v6.2. and removed missing-translation-status This PR does not have translation status info. labels Jul 26, 2022
@TomShawn TomShawn self-assigned this Jul 26, 2022
@Oreoxmt Oreoxmt self-requested a review July 26, 2022 07:03
@Oreoxmt Oreoxmt added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Jul 26, 2022
@TomShawn TomShawn added the area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. label Jul 26, 2022
@wjhuang2016
refine
360a5d6 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
TomShawn
TomShawn reviewed Jul 26, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@wjhuang2016
fix
8887c3d 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
@wjhuang2016
refine
cb36d55 
Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>
TomShawn
TomShawn reviewed Jul 26, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
TomShawn
TomShawn approved these changes Jul 26, 2022
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 26, 2022
@easonn7
Copy link
Collaborator

easonn7 commented Jul 26, 2022

LGTM，这个是内部保护开关，默认开，不建议放开到官网文档，预定 7.0 后废弃该参数。

TomShawn
TomShawn reviewed Jul 26, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
Oreoxmt
Oreoxmt approved these changes Jul 26, 2022
View reviewed changes
Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 26, 2022
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 26, 2022
TomShawn
TomShawn reviewed Jul 26, 2022
View reviewed changes
system-variables.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 967c700

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 26, 2022
@ti-chi-bot ti-chi-bot merged commit 8ed7920 into pingcap:master Jul 26, 2022
@TomShawn TomShawn mentioned this pull request Jul 27, 2022
Merged
12 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@djshow832 djshow832 Awaiting requested review from djshow832

@easonn7 easonn7 Awaiting requested review from easonn7

Assignees

@TomShawn TomShawn

Labels
area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v6.2 This PR/issue applies to TiDB v6.2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@wjhuang2016 @ti-chi-bot @easonn7 @TomShawn @Oreoxmt @shichun-0415